Sem;colon wrote:with my modification of the system plugin,
Where do i find this modified plugin? Or if didn't released it here, can you send it to me please?
Could you show me an example/situation for when .SetMute() has a problem with a non Boolean arg? I use both a 0 (zero) and 1 and there is no problem.Sem;colon wrote:.GetMute() returns an integer, not a boolean while .SetMute() needs Boolean. Otherwise I would have never done the "==1" stuff in the first place. But I changed it to this now:
OKSem;colon wrote:hmm, no, sorry, I can't reproduce it any more (don't know what I did back then, but I remember getting an error or at least it wasn't working...)
Apparently I typecast the result to Boolean, so I can remove that.Well, if integer is the way to go, I'm fine, I can change the plugin, but then I'd ask you to change OnNotify Notify.Muted to integer as well, for consistency, as this is Boolean.
jonib wrote:So the question should we keep it as an integer that the API gives us or change it to Boolean? I kinda like it to be a Boolean as it seems more clear that Mute is True or False.
So it's defined as Boolean everywhere, I like it to Boolean so I'll make it Boolean, thanks for the input.Sem;colon wrote:I agree, but if the system default is int somehow, so that's OK for me as well. It should just be consistent.
So, from my point, whatever you prefer!
Users browsing this forum: No registered users and 2 guests