EG stuff that bugs me...

Got a good idea? You can suggest new features here.
Snowbird
Experienced User
Posts: 364
Joined: Fri Jul 03, 2009 10:04 am

Re: EG stuff that bugs me...

Post by Snowbird » Thu Nov 09, 2017 5:26 pm

Hi all,

if I may suggest, I have 2 things that bug me, but fortunately I have found a workaround :), I think it would be a nice addition in a future release of EG.

1. Shortcut for ClearLog

Image

file to modify : EventGhost\eg\Classes\MainFrame\__init__.py
Line number : around line # 330
Replace this : Append("ClearLog")
By this : Append("ClearLog", "\tCtrl+L")






2. Display Date in Log viewer

Image

file to modify : EventGhost\eg\Classes\MainFrame\LogCtrl.py
Line number : around line # 242
Replace this : strftime(" %H:%M:%S ", localtime(when)) +
By this : strftime(" %d/%m %H:%M:%S ", localtime(when)) +


Just suggesting, I'm used to change those files in every new EG release, and I can continue doing it, but who knows maybe others may find this useful as well, and it would be something that could be added in a future release.

User avatar
kgschlosser
Site Admin
Posts: 5200
Joined: Fri Jun 05, 2015 5:43 am
Location: Rocky Mountains, Colorado USA

Re: EG stuff that bugs me...

Post by kgschlosser » Thu Nov 09, 2017 9:29 pm

ok so a keyboard shortcut for clear log and I do also agree with you on the date part. this has come up a number of times.. the keyboard shortcut shouldn't be an issue at all. I may get one step further with the log times and give the user the ability to format it however they want.

I have to make sure the keyboard shortcut doesn't conflict with anything else.
If you like the work I have been doing then feel free to Image

Snowbird
Experienced User
Posts: 364
Joined: Fri Jul 03, 2009 10:04 am

Re: EG stuff that bugs me...

Post by Snowbird » Tue Feb 27, 2018 5:08 pm

Hi,
Just wondering if those 2 changes regarding the Log are planned for anytime soon ? as they don't appear to be time consuming.
Thanks.

User avatar
kgschlosser
Site Admin
Posts: 5200
Joined: Fri Jun 05, 2015 5:43 am
Location: Rocky Mountains, Colorado USA

Re: EG stuff that bugs me...

Post by kgschlosser » Wed Feb 28, 2018 12:43 am

dont know. haven't discussed it.
If you like the work I have been doing then feel free to Image

Snowbird
Experienced User
Posts: 364
Joined: Fri Jul 03, 2009 10:04 am

Re: EG stuff that bugs me...

Post by Snowbird » Wed Feb 28, 2018 7:59 am

ok, is there a request made on github (if it's right the place to do this ?)

User avatar
kgschlosser
Site Admin
Posts: 5200
Joined: Fri Jun 05, 2015 5:43 am
Location: Rocky Mountains, Colorado USA

Re: EG stuff that bugs me...

Post by kgschlosser » Wed Feb 28, 2018 8:41 am

there isn't one.

Are you familiar with GitHub at all?? You should issue a Pull Request with the changes you have made. this would speed up the process of getting it added. I can walk you through the process if you want (tomorrow.)
If you like the work I have been doing then feel free to Image

Snowbird
Experienced User
Posts: 364
Joined: Fri Jul 03, 2009 10:04 am

Re: EG stuff that bugs me...

Post by Snowbird » Wed Feb 28, 2018 8:57 am

No I'm not familiar with it at all :) but I'm eager to learn if you're not afraid to waste your time with a total noob :D
send me a PM whenever you're ready, thanks ;)

User avatar
topix
Experienced User
Posts: 441
Joined: Sat May 05, 2007 3:43 pm
Location: Germany
Contact:

Re: EG stuff that bugs me...

Post by topix » Wed Feb 28, 2018 12:43 pm

I've made a pull request which adds the datestamp as an option to the view menu.

Snowbird
Experienced User
Posts: 364
Joined: Fri Jul 03, 2009 10:04 am

Re: EG stuff that bugs me...

Post by Snowbird » Wed Feb 28, 2018 2:08 pm

Thank you !!!! I've installed the WIP setup and it works perfectly, thank you so much for this addition !!

If I may quibble :), I think it would have been better to not display the year as it's not very useful and takes some space for nothing, just saying, I can live with it, no worries ;)

Snowbird
Experienced User
Posts: 364
Joined: Fri Jul 03, 2009 10:04 am

Re: EG stuff that bugs me...

Post by Snowbird » Wed Feb 28, 2018 2:12 pm

I have noticed something else while installing the latest WIP version (I should probably open another topic for this), I can not add the MQTT plugin in EG anymore, I tried to reinstall it but at the end of the installation the MQTT configuration panel opens and I can not click on the [OK] button to finish the installation, because it's greyed out... it was working flawlessly on RC4, I'm using the latest version 1.2.2 that can be found here :
https://drive.google.com/drive/folders/ ... k04dXNzYzA

it's easily reproducible, just try it. Does the plugin need some update to work with the WIP version ? or is there something missing in the WIP version that prevents this plugin to install ? or am I doing something wrong ?

Thank you again for your work, very appreciated ! :wink:

User avatar
topix
Experienced User
Posts: 441
Joined: Sat May 05, 2007 3:43 pm
Location: Germany
Contact:

Re: EG stuff that bugs me...

Post by topix » Wed Feb 28, 2018 3:44 pm

Snowbird wrote:
Wed Feb 28, 2018 2:08 pm
I think it would have been better to not display the year as it's not very useful and takes some space for nothing
I thought about making it configurable, but that would have made it complexer and i'm lazy :D (I use %x to display the date. This will use the short local date representation.)

Snowbird wrote:
Wed Feb 28, 2018 2:12 pm
I can not click on the [OK] button to finish the installation, because it's greyed out
That's a "feature" we introduced. In the MQTT config panel click on Abort/Restart all and the Ok button will be enabled.
Seems we have to rework that feature a bit.

Snowbird
Experienced User
Posts: 364
Joined: Fri Jul 03, 2009 10:04 am

Re: EG stuff that bugs me...

Post by Snowbird » Wed Feb 28, 2018 4:43 pm

topix wrote:
Wed Feb 28, 2018 3:44 pm
Snowbird wrote:
Wed Feb 28, 2018 2:08 pm
I think it would have been better to not display the year as it's not very useful and takes some space for nothing
I thought about making it configurable, but that would have made it complexer and i'm lazy :D (I use %x to display the date. This will use the short local date representation.)
Well, I know a lot about laziness LOL :D and I totally understand you, no worries, there's no need to make it configurable anyway, just remove the year when you get a chance (no hurry) and it will be more than sufficient for 99% EG'ers ;).

topix wrote:
Wed Feb 28, 2018 3:44 pm
Snowbird wrote:
Wed Feb 28, 2018 2:12 pm
I can not click on the [OK] button to finish the installation, because it's greyed out
That's a "feature" we introduced. In the MQTT config panel click on Abort/Restart all and the Ok button will be enabled.
Seems we have to rework that feature a bit.
LOL ok :) I like this "feature", I did your trick and it worked, I was able to click on [OK], and the plugin is now installed successfully, but now I have another issue, I can't add any MQTT action :) So I think, work is in progress and I should not use this version, I will revert to RC4 for now. If you're interested, here's the error I get when I try to add an MQTT action :

Code: Select all

28/02/2018  17:33:28   Traceback (most recent call last) (WIP-2018.02.28-12.41.55):
28/02/2018  17:33:28     File "C:\Program Files (x86)\EventGhost\eg\Classes\TaskletDialog.py", line 162, in ProcessingTask
28/02/2018  17:33:28       self.Configure(*args, **kwargs)
28/02/2018  17:33:28     File "C:\Program Files (x86)\EventGhost\eg\Classes\ConfigDialog.py", line 106, in Configure
28/02/2018  17:33:28       treeItem.Configure(*args)
28/02/2018  17:33:28     File "C:\Program Files (x86)\EventGhost\eg\Classes\ActionItem.py", line 80, in Configure
28/02/2018  17:33:28       return self.executable.Configure(*args)
28/02/2018  17:33:28     File "C:\ProgramData\EventGhost\plugins\MQTT Client\__init__.py", line 1593, in Configure
28/02/2018  17:33:28       qosCtrl = panel.SpinIntCtrl(qos, min=0, max=2)
28/02/2018  17:33:28     File "C:\Program Files (x86)\EventGhost\eg\Classes\ControlProviderMixin.py", line 116, in SpinIntCtrl
28/02/2018  17:33:28       return eg.SpinIntCtrl(self, -1, value, *args, **kwargs)
28/02/2018  17:33:28     File "C:\Program Files (x86)\EventGhost\eg\Classes\SpinIntCtrl.py", line 58, in __init__
28/02/2018  17:33:28       **kwargs
28/02/2018  17:33:28     File "C:\Program Files (x86)\EventGhost\eg\Classes\SpinNumCtrl.py", line 140, in __init__
28/02/2018  17:33:28       **kwargs
28/02/2018  17:33:28     File "C:\Program Files (x86)\EventGhost\eg\WinApi\wx_patches\__init__.py", line 31, in __init__
28/02/2018  17:33:28       super(_NumCtrl, self).__init__(parent, id, value, *args, **kwargs)
28/02/2018  17:33:28     File "wx\lib\masked\numctrl.pyc", line 618, in __init__
28/02/2018  17:33:28     File "C:\Program Files (x86)\EventGhost\eg\WinApi\wx_patches\__init__.py", line 35, in _set_parameters
28/02/2018  17:33:28       self.SetValue(self._hold_value)
28/02/2018  17:33:28     File "wx\lib\masked\numctrl.pyc", line 1281, in SetValue
28/02/2018  17:33:28     File "wx\lib\masked\numctrl.pyc", line 1625, in _toGUI
28/02/2018  17:33:28   ValueError: value 0 exceeds the integer width of the control (1)

User avatar
kgschlosser
Site Admin
Posts: 5200
Joined: Fri Jun 05, 2015 5:43 am
Location: Rocky Mountains, Colorado USA

Re: EG stuff that bugs me...

Post by kgschlosser » Thu Mar 01, 2018 4:23 am

I discovered that flaw with the plugin configs as well. the intention was for the Action dialogs if memory serves. but because everything uses the same mechanism for the dialogs we are going to have to add some instance checking to know when and when not to gray the button out.
If you like the work I have been doing then feel free to Image

Snowbird
Experienced User
Posts: 364
Joined: Fri Jul 03, 2009 10:04 am

Re: EG stuff that bugs me...

Post by Snowbird » Thu Mar 01, 2018 8:46 am

ok, thanks for clarifying this.

BTW, you forgot to add the shortcut to clear the log :

Code: Select all

file to modify : EventGhost\eg\Classes\MainFrame\__init__.py
Line number : around line # 330
Replace this : Append("ClearLog")
By this : Append("ClearLog", "\tCtrl+L")
would be nice to add this as well on the next occasion, thank you.

Post Reply