SchedulGhost

Questions and comments specific to a particular plugin should go here.
krambriw
Plugin Developer
Posts: 2570
Joined: Sat Jun 30, 2007 2:51 pm
Location: Stockholm, Sweden
Contact:

Re: SchedulGhost

Post by krambriw » Thu Oct 14, 2010 3:08 pm

Dear Pako,

I have tested your latest version for a while and I would like to report the following: In general it is working fine except of some issues, described below

1) The configuration of a schedule to work as an egg-timer works as you described but it is for the user not 100% intuitive, if possible I would suggest to add a set-up page that looks like the picture below

A new type of schedule "Timer" is selected and then the new page is displayed
Image1.jpg
2) When I start the schedule the start event and stop events are correctly generated but idf I restart the schedule before it stopped, I get two instances running. I think there should be a kind of "abort at restart" so that the first is stopped and then it is restarted. See the part of the log below
Image3.jpg
3) I receive an error message if I push button "Show SchedulGhost manager..." and then "Add new" before I press the OK button if the plugin is just added new

Code: Select all

17:04:29   Traceback (most recent call last) (1397):
17:04:29     File "C:\Program Files\EventGhost\plugins\SchedulGhost\__init__.py", line 1329, in onButton
17:04:29       empty = [1, "", -1, [], "", self.plugin.prefix, "", "", ""]
17:04:29   AttributeError: 'SchedulGhost' object has no attribute 'prefix'

Otherwise working very well,
Best regards, Walter

User avatar
Pako
Plugin Developer
Posts: 2294
Joined: Sat Nov 11, 2006 1:31 pm
Location: Czech Republic
Contact:

Re: SchedulGhost

Post by Pako » Thu Oct 14, 2010 4:41 pm

Dear Walter,
I thank you for the report. I can at this point to say this:
1) For this proposal I do not have a great understanding. The schedule, which is defined in such a manner is really no schedule.
Do not belong among the other types of schedules. And last but not least, this would mean big changes in the code.
I think it will be better at the appropriate place to put a meaningful tooltip, or to create a detailed wiki page and put a link to the wiki page on this tooltip.
2) For this problem I look soon, it will probably not difficult.
3) Same as Item 2.
Note: The wiki page I intend to do in any case. But for me it is very difficult due to lack of knowledge of English.

Best regards, Pako
You know flattr ? You can Image

krambriw
Plugin Developer
Posts: 2570
Joined: Sat Jun 30, 2007 2:51 pm
Location: Stockholm, Sweden
Contact:

Re: SchedulGhost

Post by krambriw » Fri Oct 15, 2010 6:22 am

Dear Pako,

It is of course your decision how much you want to do and how good you want to make your creation. I think the plugin is very good and nice looking and should therefore always get the best possible improvements

Maybe I try to explain again would I meant

I noticed that when you select a schedule type from the drop-down list, you change the content of the GUI dialog. I thought it would not so much code work to add another schedule type that could then have the GUI I tried to indicate with the picture above. If every new schedule type cause a lot of code changes, I understand if you try to avoid it

Anyway, if you would add a new type, you should of course set the necessary variables by the code like an old start date etc to make the function work. What is a problem from useability point of view is that I have to set (for the user) meaningless variables just to make the thing work. Of course tool-tip and wiki's can help but it is not an elegant solution

I think the plugin you made is elegant and deserves elegance everywhere...
The schedule, which is defined in such a manner is really no schedule.
Do not belong among the other types of schedules
This is a matter of opinion. Mine is that it could very well belong here as a schedule type. It is actually a scheduling you are creating with a start and stop event. Also the egg-clock is in fact a kind of schedule

Best regards, Walter

User avatar
Pako
Plugin Developer
Posts: 2294
Joined: Sat Nov 11, 2006 1:31 pm
Location: Czech Republic
Contact:

Re: SchedulGhost

Post by Pako » Sat Oct 16, 2010 6:30 am

Dear Walter,
Okay, you persuaded me. I will try to implement your proposal in its entirety.
I have an idea how to avoid such a large change in the code, which I feared. Perhaps it will be possible to do so.
Best regards, Pako.
You know flattr ? You can Image

krambriw
Plugin Developer
Posts: 2570
Joined: Sat Jun 30, 2007 2:51 pm
Location: Stockholm, Sweden
Contact:

Re: SchedulGhost

Post by krambriw » Sat Oct 16, 2010 7:34 am

Dear Pako, my friend
I'm happy to hear, take your time, it will be a pleasure to test & see your new version!

My best regards, Walter

User avatar
Pako
Plugin Developer
Posts: 2294
Joined: Sat Nov 11, 2006 1:31 pm
Location: Czech Republic
Contact:

Re: SchedulGhost

Post by Pako » Sat Oct 16, 2010 3:54 pm

New version 0.0.6 released. News:
- added action "Show currently running egg-timers"
- added "Time span" schedule type
- titlebar of every window displays SchedulGhost icon
- some bugfixes

Pako
Attachments
RunningEggTimers.jpg
You know flattr ? You can Image

krambriw
Plugin Developer
Posts: 2570
Joined: Sat Jun 30, 2007 2:51 pm
Location: Stockholm, Sweden
Contact:

Re: SchedulGhost

Post by krambriw » Mon Oct 18, 2010 10:11 am

Dear Pako, since yesterday, your new version works excellent including the new "Time span" schedule type. I think it is now very intuitive to understand the type and definitions

Best regards, Walter

User avatar
Pako
Plugin Developer
Posts: 2294
Joined: Sat Nov 11, 2006 1:31 pm
Location: Czech Republic
Contact:

Re: SchedulGhost

Post by Pako » Mon Oct 18, 2010 10:20 am

Dear Walter,
Thank you for the good news.
I hope that now you finally do check the English strings. :)
Best regards, Pako
You know flattr ? You can Image

krambriw
Plugin Developer
Posts: 2570
Joined: Sat Jun 30, 2007 2:51 pm
Location: Stockholm, Sweden
Contact:

Re: SchedulGhost

Post by krambriw » Mon Oct 18, 2010 11:31 am

Hi Pako,
I have attached a version where I have made changes to the text strings directly in the file, it was the easiest way. I use ultraedit and maybe in your editor you can also do file compare to see all changes I have made
__init__.py
(135.69 KiB) Downloaded 375 times
I had some thoughts about the phrases below but I think I got it right. You can test and see, here it works fine for me
Best regards, Walter

Code: Select all

        holidCheck_1 = "Do not trigger events for a chosen day if it happens to be a holiday"
        holidCheck_2 = "Do also trigger events for a non-chosen day if it happens to be a holiday"
#        holidCheck_1 = "If some marked work day falls on holiday, it's like when he is not marked"
#        holidCheck_2 = "If some not-marked work day falls on holiday, it's like when he is marked"

User avatar
Pako
Plugin Developer
Posts: 2294
Joined: Sat Nov 11, 2006 1:31 pm
Location: Czech Republic
Contact:

Re: SchedulGhost

Post by Pako » Mon Oct 18, 2010 3:08 pm

Dear Walter!
Thank you very very much for your work.
I am very satisfied, but I have one question. In lines 117 and 119 is used word in the form of selected,
while in line 3131 is used word in the form of select. I think it should be identical in all cases.
I need to make clear it.
Best regards, Pako
You know flattr ? You can Image

krambriw
Plugin Developer
Posts: 2570
Joined: Sat Jun 30, 2007 2:51 pm
Location: Stockholm, Sweden
Contact:

Re: SchedulGhost

Post by krambriw » Mon Oct 18, 2010 4:08 pm

Dear Pako, I missed that, you are correct!

I would think the following would be fine

Code: Select all

    toolTipFolder = "Press button and browse to select a folder ..."
    toolTipFile = "Press button and browse to select a logfile ..."

Code: Select all

        toolTipFile = "Press button and browse to select a wave file ..."

Best regards, Walter

PS If you support playing other files than wave files (like mp3 or others) maybe the phrase should be

Code: Select all

        toolTipFile = "Press button and browse to select a sound file ..."

but then we need to find also other places where "wave" is written

PS I tested with mp3 and it did not work so we can leave it with wave files

User avatar
Pako
Plugin Developer
Posts: 2294
Joined: Sat Nov 11, 2006 1:31 pm
Location: Czech Republic
Contact:

Re: SchedulGhost

Post by Pako » Tue Oct 19, 2010 6:38 am

Dear Walter!
Once again, thank you for your cooperation.
From this moment the plugin file (version 0.1.0 just now) is located in the SVN repository.
Link is found in the initial post of topic.
Best regards, Pako
You know flattr ? You can Image

krambriw
Plugin Developer
Posts: 2570
Joined: Sat Jun 30, 2007 2:51 pm
Location: Stockholm, Sweden
Contact:

Re: SchedulGhost

Post by krambriw » Tue Oct 19, 2010 8:07 am

Dear Pako,
I'm happy to be able to help with such things. You made a great plugin, very functional and useful (and good looking too)

Best regards, Walter

User avatar
Pako
Plugin Developer
Posts: 2294
Joined: Sat Nov 11, 2006 1:31 pm
Location: Czech Republic
Contact:

Re: SchedulGhost

Post by Pako » Tue Oct 19, 2010 9:01 am

krambriw wrote:You made a great plugin, very functional and useful (and good looking too)
I hope that many people will be happy to use it. This is the best award for me.
Only problem is that I do not know it. He's probably all take for granted.
I would really like to hear how this plugin commented Bitmonster (I still can not accept the fact that he left the project).
When I joined I was in this community, I did not know what Python is.
It is true that I've made some progress, but I'll never be a real programmer, as Bitmonster.
Pako
You know flattr ? You can Image

jofan
Posts: 7
Joined: Tue Sep 28, 2010 12:58 pm

Re: SchedulGhost

Post by jofan » Wed Oct 20, 2010 1:26 pm

Hi All,

Sorry this is not to do with ScheduleGhost (its a query on the Directory Watcher Plugin) , but i couldnt find any link to create a new thread so hopefully someone can move this to the correct place...

With regards to Directory Watcher is there any way that you can monitor different directories and have unique events triggered for each (ie one for a Music folder, one for a Photos folder), at present it appears that the plugin only generates a DirectoryWatcher.Updated event without any option for providing a suffix etc to differentiaite witch Directory?

Kind regards, J

EG is an absolutely fantastic free application!! thanks

Post Reply