Missing GetMute in System.py

[hotbuddha]

This is not really a bug, just a missing method/function. I found this was missing while writing a plugin which I am still working on. There is a GetMute available in SoundMixerEx (windows XP version looks like) but that is not available in the System plugin __init__.py which has a wrapper to a Vista Dll to overrides certain audio functions/methods (like SetMasterVolume() and ToggleMute()). This is despite that all the code pieces needed to create a GetMute function/method for Vista/Win7 is pretty much already there in the System py file and the Vista DLL. I have made the changes in my own local isntall and have been testing my changes for several releases now through my own plugin on a Win7 machine, it works just fine for me. I am using latest version 3.7.r1486 now, just upgraded this evening from 1482 (I think), and no problems with new version either. Looks like System plugin has not changed for a while, I did a diff before upgrading the last two builds I snagged and saw no other changes to the file.

So, I have very thoroughly tested my code from calling within Python through my plugin code, however I have only mildly tested the GUI action, but it generally seems to work on Win7, and should be the same on Vista considering I did not actually change any code that was already executing, just wrapping the same code from Vista DLL that was already running under ToggleMute.

Here is my System.py code with GetMute added, I would really appreciate if this could be added to base so it will be there when I release my own plugin that really needs this code.

Regards,
HotBuddha

[Pako]

Thank you, incorporated in version r1494.

Pako

[hotbuddha]

Thanks that is outstanding. I have XP loaded virtually on my PC now, so when I get the chance I will test XP and if any changes needed I will post back.