Congratulations!
I think that at this moment I can not have anything significant reproach.
I only do not know, why there is used SystemExit().
I would at that point simply used break.
But I am not a competent person who can assess it !
Pako
Notice: This forum has been recovered from an old backup, so some content, links, and dates may be outdated. The forum is currently read-only while we restore sign-in and registration functionality. Details
If you find this forum valuable and would like to help keep it online, donations to help cover hosting and domain costs are greatly appreciated, but never expected. You can support the forum through Buy Me a Coffee or Ko-fi. Thank you for helping preserve the EventGhost community.
If you find this forum valuable and would like to help keep it online, donations to help cover hosting and domain costs are greatly appreciated, but never expected. You can support the forum through Buy Me a Coffee or Ko-fi. Thank you for helping preserve the EventGhost community.
smooth volume change
-
jitterjames
- Experienced User
- Posts: 677
- Joined: Thu Aug 13, 2009 4:36 pm
- Location: Quebec, Canada
- Contact:
Re: smooth volume change
ya, break seems to work fine.
Moving right along, I've added the mute/unmte/toggle functions. settings for volume and speed of mute are set in the global settings for the plugin.
see the first post
Moving right along, I've added the mute/unmte/toggle functions. settings for volume and speed of mute are set in the global settings for the plugin.
see the first post
-
Pako
- Plugin Developer
- Posts: 2294
- Joined: Sat Nov 11, 2006 1:31 pm
- Location: Czech Republic
- Contact:
Re: smooth volume change
In addition to the one note I have nothing to say.
The exception is that the plugin works only in the English language.
You may want to be easy to make a version for other languages.
In that case, you must follow the practices described here.
In short, all text strings to be placed into a reserved class 'Text'.
Pako
The exception is that the plugin works only in the English language.
You may want to be easy to make a version for other languages.
In that case, you must follow the practices described here.
In short, all text strings to be placed into a reserved class 'Text'.
Pako
-
jitterjames
- Experienced User
- Posts: 677
- Joined: Thu Aug 13, 2009 4:36 pm
- Location: Quebec, Canada
- Contact:
-
jitterjames
- Experienced User
- Posts: 677
- Joined: Thu Aug 13, 2009 4:36 pm
- Location: Quebec, Canada
- Contact:
Re: smooth volume change
OK, I added the text class, instead of using strings directly in the configuration.
Is that all I need to do? I don't know how the alternate languages work...
I don't see anything else that needs to be done, unless someone has some requests.
jitter
Is that all I need to do? I don't know how the alternate languages work...
I don't see anything else that needs to be done, unless someone has some requests.
jitter
-
Pako
- Plugin Developer
- Posts: 2294
- Joined: Sat Nov 11, 2006 1:31 pm
- Location: Czech Republic
- Contact:
Re: smooth volume change
I will try to do a translation into Czech language and see if it is okay.
But there is a problem: just now does not work command line option "-translate".
I'll play with it and hopefully I somehow passed through the problem.
Pako
But there is a problem: just now does not work command line option "-translate".
I'll play with it and hopefully I somehow passed through the problem.
Pako
-
Pako
- Plugin Developer
- Posts: 2294
- Joined: Sat Nov 11, 2006 1:31 pm
- Location: Czech Republic
- Contact:
Re: smooth volume change
I had to make some minor changes to make it right.
I found that the directory name must match the name of plugin.
Therefore, I renamed the class "SmoothVolPlugin" to "SmoothVolume" (name "Plugin" in the folder "plugins" has no meaning).
I still have one comment. Also return informations 'already muted' and 'not muted' should be in the class "text".
Here are examples of how it looks in the Czech version of EventGhost:
Pako
I found that the directory name must match the name of plugin.
Therefore, I renamed the class "SmoothVolPlugin" to "SmoothVolume" (name "Plugin" in the folder "plugins" has no meaning).
I still have one comment. Also return informations 'already muted' and 'not muted' should be in the class "text".
Here are examples of how it looks in the Czech version of EventGhost:
- Attachments
-
- __init__.py
- Version 0.43
- (5.81 KiB) Downloaded 269 times
-
jitterjames
- Experienced User
- Posts: 677
- Joined: Thu Aug 13, 2009 4:36 pm
- Location: Quebec, Canada
- Contact:
Re: smooth volume change
thanks Pako. For some reason I was never notified of this post and am just reading it now.
-
loveleejohn
- Experienced User
- Posts: 133
- Joined: Thu Dec 10, 2015 12:09 am
Re: smooth volume change
Just wanted to stop by to say thanks a million for this plugin! It's definitely very helpful when I play music in eventghost! 