Page 2 of 2
Re: smooth volume change
Posted: Sun Oct 25, 2009 4:05 pm
by Pako
Congratulations!
I think that at this moment I can not have anything significant reproach.
I only do not know, why there is used SystemExit().
I would at that point simply used break.
But I am not a competent person who can assess it !
Pako
Re: smooth volume change
Posted: Sun Oct 25, 2009 8:46 pm
by jitterjames
ya, break seems to work fine.
Moving right along, I've added the mute/unmte/toggle functions. settings for volume and speed of mute are set in the global settings for the plugin.
see the first post
Re: smooth volume change
Posted: Mon Oct 26, 2009 7:29 pm
by Pako
In addition to the one note I have nothing to say.
The exception is that the plugin works only in the English language.
You may want to be easy to make a version for other languages.
In that case, you must follow the practices described
here.
In short, all text strings to be placed into a reserved class 'Text'.
Pako
Re: smooth volume change
Posted: Mon Oct 26, 2009 8:01 pm
by jitterjames
noted. I will see to it. Thanks
Re: smooth volume change
Posted: Fri Nov 06, 2009 2:30 am
by jitterjames
OK, I added the text class, instead of using strings directly in the configuration.
Is that all I need to do? I don't know how the alternate languages work...
I don't see anything else that needs to be done, unless someone has some requests.
jitter
Re: smooth volume change
Posted: Sat Nov 07, 2009 7:36 pm
by Pako
I will try to do a translation into Czech language and see if it is okay.
But there is a problem: just now does not work command line option "-translate".
I'll play with it and hopefully I somehow passed through the problem.
Pako
Re: smooth volume change
Posted: Sun Nov 08, 2009 11:22 am
by Pako
I had to make some minor changes to make it right.
I found that the directory name must match the name of plugin.
Therefore, I renamed the class "SmoothVolPlugin" to "SmoothVolume" (name "Plugin" in the folder "plugins" has no meaning).
I still have one comment. Also return informations 'already muted' and 'not muted' should be in the class "text".
Here are examples of how it looks in the Czech version of EventGhost:
Pako
Re: smooth volume change
Posted: Sun Dec 27, 2009 12:33 pm
by jitterjames
thanks Pako. For some reason I was never notified of this post and am just reading it now.
Re: smooth volume change
Posted: Fri Feb 26, 2016 4:03 am
by loveleejohn
Just wanted to stop by to say thanks a million for this plugin! It's definitely very helpful when I play music in eventghost!
