EventGhost

Scope wrote:Thank you for a wonderful plugin!

There are some bugs in it though
When you send a command, the plugin does not wait for the ACK. This means that if you send two commands after eachother, the plugin will not work correctly.
I am like you a newbie in python, but I will look into the problem if you don't have time.

Kind regards,
Torbj├Ârn Westerlund.

If I understand your problem correctly it should be fixed now in V1.0

New Update V1.2 on first page!

woggy wrote:

Scope wrote:Thank you for a wonderful plugin!

There are some bugs in it though
When you send a command, the plugin does not wait for the ACK. This means that if you send two commands after eachother, the plugin will not work correctly.
I am like you a newbie in python, but I will look into the problem if you don't have time.

Kind regards,
Torbj├Ârn Westerlund.

If I understand your problem correctly it should be fixed now in V1.0

Thanks for the update! But the bug is not fixed. The problem is that the implementation is asynchronous.
There is no lock-mechanism after writing to the serialport. When you send a command (write to the serialport) you have to wait for the reader-thread to handle the
acknowledge of that command. For instance you send "ka 01 01" (Power on, 3 bytes) to the serialport. The reader-thread reads two bytes of the acknowledge "OK/NG". And then you send another command while there is still data to read from the current acknowledgment. This will screw up the communication with the TV.
The flow must be like this:

>Lock read and write
* Write command to serialport
* Wait for acknowledgment
* Read and handle complete acknowledgment
< Release read and write lock

If you don't want to lock up Eventghost by sending alot of commands which are waiting for the lock, then you have to create some sort of work-queue with a dedicated thread where you queue all commands which are about to be sent, and handle them one at a time when the lock is released.
But I don't think that will be necessary. For instance, the irblaster USBUIRT works that way, it will block Eventghost until it has sent it's IRCode (even though there is no ack).

But again thanks for the update! And as I said before, if you don't have time to fix this I will try to have a look at it myself (haven't had the time yet though )

/ Torbj├Ârn Westerlund

I get this error message each time i start EG. Any way to fix it?

1. You must add to the top of plugin the line: # -*- coding: utf-8 -*-
2. You must modify the line with the name of the author as follows: author = u"Niclas H\xe5kansson",
3. Missing required parameter guid
4. In the plugin is a serious mistake. If there is this plugin in the folder plugins, can not run EventGhost with the parameter -translate .

Pako

Thx a lot, Pako. It works fine!

Pako wrote:1. You must add to the top of plugin the line: # -*- coding: utf-8 -*-
2. You must modify the line with the name of the author as follows: author = u"Niclas H\xe5kansson",
3. Missing required parameter guid
4. In the plugin is a serious mistake. If there is this plugin in the folder plugins, can not run EventGhost with the parameter -translate .

Pako

I have added bugfix 1,2,3 and Cleaned up / changed the code in V1.3 but I can't find the serious mistake =(
woggy

Scope wrote:

woggy wrote:

Scope wrote:Thank you for a wonderful plugin!

There are some bugs in it though
When you send a command, the plugin does not wait for the ACK. This means that if you send two commands after eachother, the plugin will not work correctly.
I am like you a newbie in python, but I will look into the problem if you don't have time.

Kind regards,
Torbj├Ârn Westerlund.

If I understand your problem correctly it should be fixed now in V1.0

Thanks for the update! But the bug is not fixed. The problem is that the implementation is asynchronous.
There is no lock-mechanism after writing to the serialport. When you send a command (write to the serialport) you have to wait for the reader-thread to handle the
acknowledge of that command. For instance you send "ka 01 01" (Power on, 3 bytes) to the serialport. The reader-thread reads two bytes of the acknowledge "OK/NG". And then you send another command while there is still data to read from the current acknowledgment. This will screw up the communication with the TV.
The flow must be like this:

>Lock read and write
* Write command to serialport
* Wait for acknowledgment
* Read and handle complete acknowledgment
< Release read and write lock

If you don't want to lock up Eventghost by sending alot of commands which are waiting for the lock, then you have to create some sort of work-queue with a dedicated thread where you queue all commands which are about to be sent, and handle them one at a time when the lock is released.
But I don't think that will be necessary. For instance, the irblaster USBUIRT works that way, it will block Eventghost until it has sent it's IRCode (even though there is no ack).

But again thanks for the update! And as I said before, if you don't have time to fix this I will try to have a look at it myself (haven't had the time yet though )

/ Torbj├Ârn Westerlund

Now you can 10 commands in a row and all of them will work, but you won't get the acks untill all of them is sent!

Pako wrote:1. You must add to the top of plugin the line: # -*- coding: utf-8 -*-
2. You must modify the line with the name of the author as follows: author = u"Niclas H\xe5kansson",
3. Missing required parameter guid
4. In the plugin is a serious mistake. If there is this plugin in the folder plugins, can not run EventGhost with the parameter -translate .

Pako

I have found the serious mistake. Actionnames can't have + - and : in their names, and they can't start with numbers. =)

Fixed now in V1.4

Nice work thanks.

Using On/Off and Screen Saver commands without issues.

I have a little problem with the aspect ratio switch.
I think there is something wrong with the Cinema Zoom and the value.
It says I should enter a value of 1-16.

If I set 7, it switches to 14:9. It should do Cinema Zoom Level 7.
If I set 10 it does switch to Cinema Zoom Level 10.
16 switches to Cinema Zoom Level 1.
22 switches to Cinema Zoom Level 7. (this is the zoom level I wanted, so its "fixed" for me


The LG manual says:

Data 01 : Normal screen
(4:3)
02 : Wide screen (16:9)
04 : Zoom
06 : Original
07 : 14:9
09 : Just Scan
0B : Full Wide
10 to 1F : Cinema Zoom 1 to 16

brotbuexe wrote:Nice work thanks.

Using On/Off and Screen Saver commands without issues.

I have a little problem with the aspect ratio switch.
I think there is something wrong with the Cinema Zoom and the value.
It says I should enter a value of 1-16.

If I set 7, it switches to 14:9. It should do Cinema Zoom Level 7.
If I set 10 it does switch to Cinema Zoom Level 10.
16 switches to Cinema Zoom Level 1.
22 switches to Cinema Zoom Level 7. (this is the zoom level I wanted, so its "fixed" for me


The LG manual says:

Data 01 : Normal screen
(4:3)
02 : Wide screen (16:9)
04 : Zoom
06 : Original
07 : 14:9
09 : Just Scan
0B : Full Wide
10 to 1F : Cinema Zoom 1 to 16

Fixed it in V1.5 on first page.

Hi Woggy,

is it possible to change the output of events with your plugin?
Because, if i request the backlight status i get the following event, as example: LG.Backlight '30'. But for an action i can only use LG.Backlight, because EG does not recognize the value behind.
If the output were something like LG.Backilight.30, EG could use the different valuesand my Macro does work.

regards,
v!

if you listen for the event LG.Backlight
you will find the value with:
eg.event.payload

Try this:

Oh, it seems i have to learn Python Script!


With your script i get the following event:

LG.Backlight.none

But the value should be: 30

True, for eg.event.payload to work you need an event (and a payload)

try to call Backlight Status.