Page 1 of 1

New AddEventDialog

Posted: Sat Dec 31, 2016 2:45 pm
by Sem;colon
The new AddEventDialog is not working for me in EG 0.5 beta 5

-Here is the error when I open it:

Code: Select all

15:20:15: 37 MainThread: Create(cls=<class 'eg.Classes.AddEventDialog.AddEventDialog'>)
15:20:15: 38 MainThread: AddEventDialog.ProcessingTask()
15:20:15: 38 MainThread: AddEventDialog.Configure(parent=<eg.Classes.MainFrame.MainFrame; proxy of <Swig Object of type 'wxFrame *' at 0x8ed0340> >)
15:20:15: 38 MainThread: AddEventDialog.__init__(style=536877120, id=-1, parent=<eg.Classes.MainFrame.MainFrame; proxy of <Swig Object of type 'wxFrame *' at 0x8ed0340> >, title='Add Event...')
15:20:15: 38 MainThread: AddEventDialog.__init__ => None
15:20:15: 38 MainThread: AddEventDialog.Affirmed()
15:20:15: 38 MainThread: AddEventDialog.FinishSetup()
15:20:15: 37 MainThread: Create => <eg.Classes.AddEventDialog.AddEventDialog; proxy of <Swig Object of type 'wxDialog *' at 0x8ef1a18> >
15:20:15: 37 MainThread: AddEventDialog.GetEvent()
Traceback (most recent call last) (0.5.0-beta5):
  File "C:\Program Files (x86)\EventGhost\eg\Classes\AddEventDialog.py", line 159, in OnExpanded
    self.tree.GetPyData(event.GetItem()).expanded = True
  File "C:\Program Files (x86)\EventGhost\eg\Classes\PluginModuleInfo.py", line 81, in __setattr__
    "%s has no attribute %s" % (self.__class__.__name__, name)
AttributeError: PluginInstanceInfo has no attribute expanded
Traceback (most recent call last) (0.5.0-beta5):
  File "C:\Program Files (x86)\EventGhost\eg\Classes\AddEventDialog.py", line 156, in OnCollapsed
    self.tree.GetPyData(event.GetItem()).expanded = False
  File "C:\Program Files (x86)\EventGhost\eg\Classes\PluginModuleInfo.py", line 81, in __setattr__
    "%s has no attribute %s" % (self.__class__.__name__, name)
AttributeError: PluginInstanceInfo has no attribute expanded
-The OK button is grayed out if you try to enter en Event manually

-A Description for the input field where you actually see the Event would be nice (maybe above), it looks a search field currently

-The Hint is missing that you can use also drag and drop to add events
addevent.PNG

Re: New AddEventDialog

Posted: Sun Jan 01, 2017 10:45 am
by topix
Sem;colon wrote:-The OK button is grayed out if you try to enter en Event manually
Did you hit Enter after typing the event name?
Sem;colon wrote:-A Description for the input field where you actually see the Event would be nice (maybe above), it looks a search field currently
The text in the textctrl is the event you will get. But i understand what you mean and will try to make it more visible.
Sem;colon wrote:-The Hint is missing that you can use also drag and drop to add events
:oops: Didn't knew or tested it 8)

Re: New AddEventDialog

Posted: Sun Jan 01, 2017 2:06 pm
by topix
I made some enhancements to the dialog (https://github.com/EventGhost/EventGhost/pull/151):
AddEventDialog.png
AddEventDialog.png (10.45 KiB) Viewed 6644 times

Re: New AddEventDialog

Posted: Sun Jan 01, 2017 8:44 pm
by Sem;colon
topix wrote:I made some enhancements to the dialog (https://github.com/EventGhost/EventGhost/pull/151):
Thank you, looks good! :D
I have one question though, why isn't it possible to resolve the plugins the Events come from? Or better, how can the list be populated? At the moment there is only a System and a <unknown> node.
topix wrote:Did you hit Enter after typing the event name?
No I didn't... How should I know that I'm supposed to hit enter?
After hitting Enter the OK button isn't greyed out any more, but I honestly didn't expect that you have to press Enter - why is that? Wouldn't it be better to activate the button whenever the Box is not empty?
topix wrote: Sem;colon wrote:
-The Hint is missing that you can use also drag and drop to add events

:oops: Didn't knew or tested it 8)
That's funny, I didn't know that as well :lol:
It's cool though and worth a hint.
I was referring to the Hint in the old add event dialog, which I guess is helpful to people that are new to EventGhost:
addevent1.PNG
addevent1.PNG (5.64 KiB) Viewed 6641 times

Re: New AddEventDialog

Posted: Mon Jan 02, 2017 6:34 am
by kgschlosser
can we also drag and drop events from the logger to populate the list in the dialog?? :-D

Re: New AddEventDialog

Posted: Mon Jan 02, 2017 8:24 am
by Pako
kgschlosser wrote:can we also drag and drop events from the logger to populate the list in the dialog??
What kind of question is that ?
Maybe, I did not understand it correctly.
However - the answer is: of course we can.
I've already used it in several plugins. As an example, I can give the Music Bee plugin (main plugin dialog) or Media Player Classic plugin (Show MPC menu action).
EventAssignement.png
EventAssignement.png (9.95 KiB) Viewed 6634 times
Pako

Re: New AddEventDialog

Posted: Fri Jan 13, 2017 9:37 am
by kgschlosser
@ Pako.

You cannot drag and drop events into the AddEvents Dialog. you can only drag and drop them into the tree.

this dialog right here
addevent.png
and also what is that menu control events assignment?? never seen that dialog before and i can't seem to locate where it is

Re: New AddEventDialog

Posted: Fri Jan 13, 2017 5:54 pm
by topix
kgschlosser wrote:and also what is that menu control events assignment?? never seen that dialog before and i can't seem to locate where it is
Don't know what you mean "menu control events"? Can explain more?

Re: New AddEventDialog

Posted: Fri Jan 13, 2017 6:06 pm
by kgschlosser
look at the image in pako's post...

what is that and where is it??

Re: New AddEventDialog

Posted: Fri Jan 13, 2017 6:09 pm
by topix
I think it will be one of:
Pako wrote:As an example, I can give the Music Bee plugin (main plugin dialog) or Media Player Classic plugin (Show MPC menu action).

Re: New AddEventDialog

Posted: Fri Jan 13, 2017 11:09 pm
by kgschlosser
i wasn't' understanding what he was saying then. I thought that was apart of the add events dialog