When closing EventGhost and at least one dialog is open...

topix · Post by **topix** » Sun Jan 22, 2017 10:37 am

https://github.com/EventGhost/EventGhost/pull/141

Please community, give your voice

kgschlosser · Post by **kgschlosser** » Sun Jan 22, 2017 6:41 pm

I can add the bell and the flashing title bar when the dialog to close all open config panels is displayed.

Let me provide a little information on what this does.

if you have 4 open action config panels. and want to close EG. currently you have to go and close them all individually before you can close EG.

this modification will bring up a yes/no box listing all of the open config panel names and asks you if you want to close them. and by selecting yes. it will go and do it for you and then close EG.

Sem;colon · Post by **Sem;colon** » Sun Jan 22, 2017 8:05 pm

One question:
If you say: Yes, close all.
Will I get another box if there are unsaved settings per dialog, or will it save all/discard all?
I mean, I may want to save the changes in panel 1, but discard the changes in panel 2...

I see that it's convenient to close all open dialogs you have at once, if nothing has changed in them.
In this case, why even notifying?

My idea would be: if there is no unsaved data in the dialog, just close it, otherwise do blink & bell.

kgschlosser · Post by **kgschlosser** » Mon Jan 23, 2017 1:17 am

nope it will just destroy them. doesn't save a thing.... that would be the purpose of the NO Button

kgschlosser · Post by **kgschlosser** » Mon Jan 23, 2017 1:22 am

good idea... I can check to see if there is unsaved data... hmmm... see this is why we put things out there.. ideas... ideas... ideas.. because that is one hell of a good one..

so deep six the dialog asking to close them.. instead check if there is unsaved data.. and if everything has been saved to close the dialog. and if one comes up that has data that needs to be saved... raise that specific dialog.. and do the blinky blinky bell thing.

and if there is a non standard dialog i will do the blinky blinky bell thing also.

I like that much better...

if anyone else is for it... say so

kgschlosser · Post by **kgschlosser** » Mon Jan 23, 2017 10:23 am

Sem;colon wrote:My idea would be: if there is no unsaved data in the dialog, just close it, otherwise do blink & bell.

DONE!

I liked that solution much better.

And I also Fixed that bloody annoying phantom dialog if you got a traceback when a config dialog was opened. forcing you to end the process because you couldn't close EG

topix · Post by **topix** » Mon Jan 23, 2017 5:53 pm

I've updated the choices for the poll, but now the previous votes are gone

kgschlosser · Post by **kgschlosser** » Tue Jan 24, 2017 8:38 am

@Sem;colon

you rock dude... that was a great idea. and it was a joy for me to code up.. because that was one of those little annoyances that would be like bouncing a ping pong ball on your head over and over and over again.... and thus far is the popular vote. it's the only option that has been voted for so far(duh!). I would be pretty shocked if someone votes any other way...

GREAT IDEA!!!

K

Sem;colon · Post by **Sem;colon** » Tue Jan 24, 2017 3:35 pm

wasn't a big deal, but I appreciate

thank you for doing the work

kgschlosser · Post by **kgschlosser** » Tue Jan 24, 2017 7:55 pm

i can type out the code... but without any ideas to give direction. my fingers are useless. In my book the ideas are what drive the project.. and ideas are what made EG a great program... so keep em coming... the more ideas and the more functionality we give EG whether it be in the core or via a plugin only makes the candy even sweeter if ya get my meaning.

kgschlosser · Post by **kgschlosser** » Sun Jan 29, 2017 7:55 pm

come on we have to have more then 6 people that use EG!!!! this is how things get added. we want to know from everyone what they would like to see happen...

EventGhost